Skip to content

Changes error message to be thrown when data out of range for DECIMAL/NUMERIC types#796

Merged
cheenamalhotra merged 5 commits intomicrosoft:devfrom
cheenamalhotra:issue787
Sep 25, 2018
Merged

Changes error message to be thrown when data out of range for DECIMAL/NUMERIC types#796
cheenamalhotra merged 5 commits intomicrosoft:devfrom
cheenamalhotra:issue787

Conversation

@cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Aug 30, 2018

Issue #787

This change now throws SQLServerException if data passed is out of range for DECIMAL/NUMERIC types.

@codecov-io
Copy link

codecov-io commented Aug 30, 2018 •
edited
Loading

Codecov Report

Merging #796 into dev will decrease coverage by 0.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #796      +/-   ##
============================================
- Coverage     48.21%   48.19%   -0.02%     
+ Complexity     2789     2777      -12     
============================================
  Files           116      116              
  Lines         27862    27858       -4     
  Branches       4641     4641              
============================================
- Hits          13434    13427       -7     
- Misses        12201    12211      +10     
+ Partials       2227     2220       -7
Flag Coverage Δ Complexity Δ
#JDBC42 47.65% <12.5%> (ø) 2733 <0> (-3) ⬇️
#JDBC43 48.09% <12.5%> (+0.01%) 2776 <0> (-7) ⬇️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.46% <0%> (+0.08%) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <100%> (+0.17%) 31 <0> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.25% <0%> (-0.65%) 87% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.46% <0%> (-0.5%) 253% <0%> (-6%)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 33.21% <0%> (-0.48%) 62% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.34% <0%> (-0.26%) 260% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.51% <0%> (-0.2%) 135% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 52.1% <0%> (-0.13%) 216% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (ø) 43% <0%> (-1%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f010285...166ab72. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.1 milestone Aug 30, 2018
@cheenamalhotra cheenamalhotra mentioned this pull request Aug 30, 2018
Closed
lilgreenbird
lilgreenbird previously approved these changes Aug 31, 2018
View reviewed changes
peterbae
peterbae previously approved these changes Sep 19, 2018
View reviewed changes
@ulvii
Copy link
Contributor

ulvii commented Sep 19, 2018

Please, add a test.

@cheenamalhotra
Copy link
Member Author

cheenamalhotra commented Sep 21, 2018

@ulvii As discussed, test will be added later (added in Backlog) with a few changes in existing Junit tests.

peterbae
peterbae previously approved these changes Sep 21, 2018
View reviewed changes
ulvii
ulvii reviewed Sep 24, 2018
View reviewed changes
@cheenamalhotra cheenamalhotra merged commit e19c524 into microsoft:dev Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ulvii ulvii ulvii approved these changes

@lilgreenbird lilgreenbird lilgreenbird left review comments

@peterbae peterbae peterbae left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @ulvii @lilgreenbird @peterbae